NFS: Use ERR_CAST() to avoid cross-structure cast
authorKees Cook <keescook@chromium.org>
Wed, 5 Apr 2017 00:08:42 +0000 (17:08 -0700)
committerKees Cook <keescook@chromium.org>
Sun, 28 May 2017 17:11:47 +0000 (10:11 -0700)
commitfe3b81b446d4ecb954f1b9dd191164a78fd278ad
tree924a9493dfc2acc2af3792c6716f407f0813d6b3
parent08332893e37af6ae779367e78e444f8f9571511d
NFS: Use ERR_CAST() to avoid cross-structure cast

When the call to nfs_devname() fails, the error path attempts to retain
the error via the mnt variable, but this requires a cast across very
different types (char * to struct vfsmount *), which the upcoming
structure layout randomization plugin flags as being potentially
dangerous in the face of randomization. This is a false positive, but
what this code actually wants to do is retain the error value, so this
patch explicitly sets it, instead of using what seems to be an
unexpected cast.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Trond Myklebust <trond.myklebust@primarydata.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/nfs/namespace.c