Disallow skipping transform and quantization
authorCheng Chen <chengchen@google.com>
Thu, 17 Jun 2021 22:36:18 +0000 (15:36 -0700)
committerCheng Chen <chengchen@google.com>
Fri, 25 Jun 2021 23:31:58 +0000 (16:31 -0700)
commitfe1c7d2d8cce13d9cd1edfe11a6703e5521ae561
tree536821981b47221dcc23a1b8a748b5fd301b0056
parenteebc5cd487a89c51ba148f6d6ac45779970f72d7
Disallow skipping transform and quantization

The encoder has a feature to skip transform and quantization based
on model rd analysis. It could happen that the model
based analysis lets the encoder skips transform and quantization, while
a bad prediction occurs, leading to bad reconstructed blocks, which
are intrusive and apparently coding errors.

We add a speed feature to guard the skipping feature.
Due to the risk of bad perceptual quality, we disallow such skipping
by default.

On hdres test set, speed 2, the coding performance difference is 0.025%,
speed difference is 1.2%, which can be considered non significant.

BUG=webm:1729

Change-Id: I48af01ae8dcc7a76c05c695f3f3e68b866c89574
vp9/encoder/vp9_block.h
vp9/encoder/vp9_rdopt.c
vp9/encoder/vp9_speed_features.c
vp9/encoder/vp9_speed_features.h