media: vcodec: Fix potential array out-of-bounds in encoder queue_setup
authorWei Chen <harperchen1110@gmail.com>
Thu, 10 Aug 2023 08:23:33 +0000 (08:23 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2023 14:11:09 +0000 (16:11 +0200)
commitfe04122b932118e968ea4ba88bdc62aa806b88d1
tree9117a1e9b981b564c941b4c04892d0a143292ea0
parent4919043ab93bb662961ffe34c55557b0aafd3bcd
media: vcodec: Fix potential array out-of-bounds in encoder queue_setup

commit e7f2e65699e2290fd547ec12a17008764e5d9620 upstream.

variable *nplanes is provided by user via system call argument. The
possible value of q_data->fmt->num_planes is 1-3, while the value
of *nplanes can be 1-8. The array access by index i can cause array
out-of-bounds.

Fix this bug by checking *nplanes against the array size.

Fixes: 4e855a6efa54 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c