dmaengine: virt-dma: Fix access after free in vchan_complete()
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Fri, 20 Dec 2019 13:11:00 +0000 (15:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2020 09:20:00 +0000 (10:20 +0100)
commitfdfd8f9ef2d3a35764e8fabc035bd0bbb382e318
tree4840f4c63ac131e21e498ce6553cae826ada26cb
parente0d2bf5a012974c2f718ce41dbff185666eae11f
dmaengine: virt-dma: Fix access after free in vchan_complete()

commit 24461d9792c2c706092805ff1b067628933441bd upstream.

vchan_vdesc_fini() is freeing up 'vd' so the access to vd->tx_result is
via already freed up memory.

Move the vchan_vdesc_fini() after invoking the callback to avoid this.

Fixes: 09d5b702b0f97 ("dmaengine: virt-dma: store result on dma descriptor")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Link: https://lore.kernel.org/r/20191220131100.21804-1-peter.ujfalusi@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/virt-dma.c