of/flattree: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 30 May 2023 16:22:02 +0000 (16:22 +0000)
committerKees Cook <keescook@chromium.org>
Wed, 14 Jun 2023 19:04:06 +0000 (12:04 -0700)
commitfdd932efaec97693e6b383df876712f590f4332a
tree7b601962ebe4ea2e7861da4ecd5be2f7fa52f4d3
parentbb07972fd64a8d666424e6e65648eed2ab758eac
of/flattree: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230530162202.983558-1-azeemshaikh38@gmail.com
arch/microblaze/kernel/prom.c