Use enum instead of "static const" in class scope
authorBehdad Esfahbod <behdad@behdad.org>
Fri, 7 Sep 2018 19:02:57 +0000 (15:02 -0400)
committerBehdad Esfahbod <behdad@behdad.org>
Fri, 7 Sep 2018 19:02:57 +0000 (15:02 -0400)
commitfda994e1d45c4d34601af7272f37ea257f92a3d8
treeae390747679171bd15ab41069c9190736516f74b
parentebe67137ab3559c2c6aaf53442ca223cb34df5af
Use enum instead of "static const" in class scope

Technically, static const needs an out-of-class definition.  Eg:

  CXXLD    libharfbuzz-subset.la
Undefined symbols for architecture x86_64:
  "OT::FeatureVariationRecord::min_size", referenced from:
      bool OT::GSUBGPOS::subset<OT::PosLookup>(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
      bool OT::GSUBGPOS::subset<OT::SubstLookup>(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
  "OT::Record<OT::LangSys>::min_size", referenced from:
      OT::Script::subset(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
  "OT::IntType<unsigned short, 2u>::min_size", referenced from:
      OT::Script::subset(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
      OT::RecordListOf<OT::Feature>::subset(hb_subset_context_t*) const  in libharfbuzz_subset_la-hb-subset.o
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status
make[4]: *** [libharfbuzz-subset.la] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
Exited with code 2
src/hb-buffer.hh
src/hb-machinery.hh
src/hb-open-file.hh
src/hb-open-type.hh
src/hb-ot-layout-common.hh
src/hb-ot-layout.cc
src/hb-set-digest.hh
src/hb-set.hh