net: fix napi_disable() logic error
authorEric Dumazet <edumazet@google.com>
Thu, 17 Nov 2022 09:26:41 +0000 (09:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Nov 2022 12:04:39 +0000 (12:04 +0000)
commitfd896e38e5df2c5b68c78eee2fc425c4dcd3b4dd
tree2c644499ca3efaf491aa6c02141f8d9a7e9f29f8
parent38461894838bbbebab54cbd5a5459cc8d1b6dd9b
net: fix napi_disable() logic error

Dan reported a new warning after my recent patch:

New smatch warnings:
net/core/dev.c:6409 napi_disable() error: uninitialized symbol 'new'.

Indeed, we must first wait for STATE_SCHED and STATE_NPSVC to be cleared,
to make sure @new variable has been initialized properly.

Fixes: 4ffa1d1c6842 ("net: adopt try_cmpxchg() in napi_{enable|disable}()")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c