Fix problems with the --dynamic-list option.
authorCary Coutant <ccoutant@google.com>
Wed, 5 Feb 2014 22:01:52 +0000 (14:01 -0800)
committerCary Coutant <ccoutant@google.com>
Thu, 6 Feb 2014 02:01:47 +0000 (18:01 -0800)
commitfd834e57ffce2f5dbe3443f034e68cebd63ee89a
tree6a5324243f95c8d47ee76b928cb3ca02076e184e
parentee1e2d4fb692736c754b42b69eb88c1f436c5f15
Fix problems with the --dynamic-list option.

PR gold/13577 complains that even though symbols listed in
the --dynamic-list script are exported, they are still bound symbolically
if -Bsymbolic is also used. There are two underlying problems here.
First, -Bsymbolic should be overridden by --dynamic-list, since the
dynamic list provides an explicit list of symbols that are not bound
within the library, and if we go ahead and set DT_SYMBOLIC, then the
dynamic loader will bind it within the library anyway. Second, gold
did not properly identify the symbols listed in the file as preemptible.

PR gold/16530 complains that symbols listed in the --dynamic-list script
can still be garbage collected. I've fixed this by checking the symbols
as they're added to the symbol table. (Unlike the --export-dynamic-symbol
option, we can't iterate over the list, because the --dynamic-list script
can have wildcards in it.)

gold/

2014-02-05  Cary Coutant  <ccoutant@google.com>

PR gold/13577
* options.cc (General_options::parse_dynamic_list):
Set have_dynamic_list_.
(General_options::General_options): Initialize have_dynamic_list_.
(General_options::finalize): Turn off -Bsymbolic and
-Bsymbolic-functions if --dynamic-list provided.
* options.h (General_options::have_dynamic_list): New function.
(General_options::have_dynamic_list_): New data member.
* symtab.h (Symbol::is_preemptible): Handle --dynamic-list
correctly.

PR gold/16530
* symtab.cc (Symbol_table::add_from_relobj): If symbol is named
in --dynamic-list, mark it.

* testsuite/Makefile.am (gc_dynamic_list_test.sh): New test case.
(dynamic_list_2): New test case.
* testsuite/Makefile.in: Regenerate.
* testsuite/dynamic_list_2.cc: New file.
* testsuite/dynamic_list_2.t: New file.
* testsuite/dynamic_list_lib1.cc: New file.
* testsuite/dynamic_list_lib2.cc: New file.
* testsuite/gc_dynamic_list_test.c: New file.
* testsuite/gc_dynamic_list_test.sh: New file.
* testsuite/gc_dynamic_list_test.t: New file.
13 files changed:
gold/options.cc
gold/options.h
gold/symtab.cc
gold/symtab.h
gold/testsuite/Makefile.am
gold/testsuite/Makefile.in
gold/testsuite/dynamic_list_2.cc [new file with mode: 0644]
gold/testsuite/dynamic_list_2.t [new file with mode: 0644]
gold/testsuite/dynamic_list_lib1.cc [new file with mode: 0644]
gold/testsuite/dynamic_list_lib2.cc [new file with mode: 0644]
gold/testsuite/gc_dynamic_list_test.c [new file with mode: 0644]
gold/testsuite/gc_dynamic_list_test.sh [new file with mode: 0755]
gold/testsuite/gc_dynamic_list_test.t [new file with mode: 0644]