afs: Fix double inc of vnode->cb_break
authorDavid Howells <dhowells@redhat.com>
Fri, 10 May 2019 22:14:41 +0000 (23:14 +0100)
committerDavid Howells <dhowells@redhat.com>
Thu, 16 May 2019 15:25:21 +0000 (16:25 +0100)
commitfd711586bb7d63f257da5eff234e68c446ac35ea
tree843b8000ed1df14647a708dde3f161e1a510a37b
parentc7226e407b6065d3bda8bd9dc627663d2c505ea3
afs: Fix double inc of vnode->cb_break

When __afs_break_callback() clears the CB_PROMISED flag, it increments
vnode->cb_break to trigger a future refetch of the status and callback -
however it also calls afs_clear_permits(), which also increments
vnode->cb_break.

Fix this by removing the increment from afs_clear_permits().

Whilst we're at it, fix the conditional call to afs_put_permits() as the
function checks to see if the argument is NULL, so the check is redundant.

Fixes: be080a6f43c4 ("afs: Overhaul permit caching");
Signed-off-by: David Howells <dhowells@redhat.com>
fs/afs/security.c