driver core: return an error when dev_set_name() hasn't happened
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 28 Aug 2023 14:58:24 +0000 (17:58 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Sep 2023 13:54:44 +0000 (15:54 +0200)
commitfd6f7ad2fd4d53fa14f4fd190f9b05d043973892
tree148c2f6ab0d6b4080ecbff4fda002ffc9defab3b
parent0bb80ecc33a8fb5a682236443c1e740d5c917d1d
driver core: return an error when dev_set_name() hasn't happened

The commit d21fdd07cea4 ("driver core: Return proper error code when
dev_set_name() fails") rewrote the logic of handling the dev_set_name()
error codes, but missed the point that initially set error value to
-EINVAL might be rewritten and hence the error path can't be triggered
at some circumstances. To fix this, make sure that error variable is
set to -EINVAL when other conditionals are false.

Reported-by: syzbot+bdfb03b1ec8b342c12cb@syzkaller.appspotmail.com
Fixes: d21fdd07cea4 ("driver core: Return proper error code when dev_set_name() fails")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230828145824.3895288-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c