define_command: Don't convert command name to lower case
authorSimon Marchi <simon.marchi@ericsson.com>
Mon, 28 Aug 2017 21:05:04 +0000 (23:05 +0200)
committerSimon Marchi <simon.marchi@ericsson.com>
Mon, 28 Aug 2017 21:05:04 +0000 (23:05 +0200)
commitfd437cbc432d5421492a5b0e371750de104cce93
tree470d6ea77aa8fa4ce9cc54528944a7cf9d1e7ffd
parent90efb6422939ca031804266fba669f77c22a274a
define_command: Don't convert command name to lower case

Commit

  Command names: make them case sensitive
  3d7b173c29900879c9a5958dd6029fd36666e57c

made command name lookup case sensitive.  However, define_command, used
when creating a user-defined command, converts the command name to
lowercase, assuming that the command name lookup works in a case
insensitive way.  This causes user-defined commands with capital letters
in their name to only be callable with a lowercase version:

  (gdb) define Foo
  Type commands for definition of "Foo".
  End with a line saying just "end".
  >print 1
  >end
  (gdb) Foo
  Undefined command: "Foo".  Try "help".
  (gdb) foo
  $1 = 1

This patch removes that conversion to lowercase, so that the user can
call the command with the same name they provided.

gdb/ChangeLog:

* cli/cli-script.c (define_command): Don't convert command name
to lower case.

gdb/testsuite/ChangeLog:

* gdb.base/commands.exp (user_defined_command_case_sensitivity):
New proc, call it from toplevel.
gdb/ChangeLog
gdb/cli/cli-script.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/commands.exp