Remove relational operators from common/offset-type.h
authorSergio Durigan Junior <sergiodj@redhat.com>
Thu, 25 Oct 2018 20:46:46 +0000 (16:46 -0400)
committerSergio Durigan Junior <sergiodj@redhat.com>
Tue, 30 Oct 2018 03:48:37 +0000 (23:48 -0400)
commitfd332753fa7050bb9d7c89147e32d285099fe402
tree83f2f3cc2b1bd6c3549d073330d5eddea3c309d0
parent9c3adfb9a409a240bb4cf087f0adeb8b1472f67a
Remove relational operators from common/offset-type.h

This patch is a follow-up of:

  https://sourceware.org/ml/gdb-patches/2018-10/msg00601.html

It removes the declaration of the relational operators for
common/offset-type.h.  As it turns out, these overloads are not being
used when a new offset type is declared, because, according to Pedro
Alves:

  I think the functions aren't called because they are templates, and
  thus the built-in (non-template) versions take precedence.  If you
  make them non-templates, then they should be called.  But, the
  built-ins are fine, so yeah, we can just remove the custom
  definitions.

The patch also adjusts the comments on the code.

No regressions introduced.

gdb/ChangeLog:
2018-10-29  Sergio Durigan Junior  <sergiodj@redhat.com>

* common/offset-type.h (DEFINE_OFFSET_REL_OP): Delete.
Adjust comments.
gdb/ChangeLog
gdb/common/offset-type.h