KVM: x86: ioapic: Fix level-triggered EOI and userspace I/OAPIC reconfigure race
authorAdamos Ttofari <attofari@amazon.de>
Thu, 8 Dec 2022 09:44:14 +0000 (09:44 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 23 Dec 2022 17:07:40 +0000 (12:07 -0500)
commitfceb3a36c29a957515d5156e5e7844ea040dc43d
treee5f20fab23470fc653c39d6fc6115bdd95a42a50
parent55c590adfe18b5380f7c4ae3696468bc5c916ee5
KVM: x86: ioapic: Fix level-triggered EOI and userspace I/OAPIC reconfigure race

When scanning userspace I/OAPIC entries, intercept EOI for level-triggered
IRQs if the current vCPU has a pending and/or in-service IRQ for the
vector in its local API, even if the vCPU doesn't match the new entry's
destination.  This fixes a race between userspace I/OAPIC reconfiguration
and IRQ delivery that results in the vector's bit being left set in the
remote IRR due to the eventual EOI not being forwarded to the userspace
I/OAPIC.

Commit 0fc5a36dd6b3 ("KVM: x86: ioapic: Fix level-triggered EOI and IOAPIC
reconfigure race") fixed the in-kernel IOAPIC, but not the userspace
IOAPIC configuration, which has a similar race.

Fixes: 0fc5a36dd6b3 ("KVM: x86: ioapic: Fix level-triggered EOI and IOAPIC reconfigure race")

Signed-off-by: Adamos Ttofari <attofari@amazon.de>
Reviewed-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20221208094415.12723-1-attofari@amazon.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/irq_comm.c