If buildtoc can't open a Pod file, that's fatal, not a warning and skip.
authorNicholas Clark <nick@ccl4.org>
Sat, 17 Dec 2011 20:32:58 +0000 (21:32 +0100)
committerNicholas Clark <nick@ccl4.org>
Mon, 19 Dec 2011 12:55:18 +0000 (13:55 +0100)
commitfcdc6846043a49b06ba005ecfc5e9064e17f049d
treeeded876ecac8b5a7403e42ae6f93d0304582d8b0
parentb1a2f073f0230f01166eb98b343be7a3f8c41f0a
If buildtoc can't open a Pod file, that's fatal, not a warning and skip.

The logic within the File::Find::find() callback was to attempt to open any
file, and if it failed, politely report a warning and run system ls -l on the
offending name. It's been the same since pod/buildtoc was added in December
1995 by commit cb1a09d0194fed9b ("This is patch.2b1g to perl5.002beta1.").

However the ls -l would never have worked, as it uses the full pathname
(from the top of the build tree), while File::Find::find() has changed the
current directory to the directory which it is scanning. The failure to open
"should" never happen, so if it does, it should be brought to a human's
attention instead of being glossed over.

The new approach takes less code.
pod/buildtoc