kdb: remove unnecessary null check of dbg_io_ops
authorCengiz Can <cengiz@kernel.wtf>
Tue, 30 Jun 2020 08:29:23 +0000 (11:29 +0300)
committerDaniel Thompson <daniel.thompson@linaro.org>
Tue, 8 Sep 2020 13:34:40 +0000 (14:34 +0100)
commitfcdb84cc5b31c2f4e333051f467264f5821bc61a
tree0e6d023fac85f8b6ff2d495cfe3cd499c71426fe
parentf75aef392f869018f78cfedf3c320a6b3fcfda6b
kdb: remove unnecessary null check of dbg_io_ops

`kdb_msg_write` operates on a global `struct kgdb_io *` called
`dbg_io_ops`.

It's initialized in `debug_core.c` and checked throughout the debug
flow.

There's a null check in `kdb_msg_write` which triggers static analyzers
and gives the (almost entirely wrong) impression that it can be null.

Coverity scanner caught this as CID 1465042.

I have removed the unnecessary null check and eliminated false-positive
forward null dereference warning.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Link: https://lore.kernel.org/r/20200630082922.28672-1-cengiz@kernel.wtf
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
kernel/debug/kdb/kdb_io.c