md: fix an incorrect NULL check in does_sb_need_changing
authorXiaomeng Tong <xiam0nd.tong@gmail.com>
Fri, 8 Apr 2022 08:37:28 +0000 (16:37 +0800)
committerSong Liu <song@kernel.org>
Mon, 25 Apr 2022 21:00:35 +0000 (14:00 -0700)
commitfc8738343eefc4ea8afb6122826dea48eacde514
tree077abb7891f767751186da52349b785a599703d4
parent57668f0a4cc4083a120cc8c517ca0055c4543b59
md: fix an incorrect NULL check in does_sb_need_changing

The bug is here:
if (!rdev)

The list iterator value 'rdev' will *always* be set and non-NULL
by rdev_for_each(), so it is incorrect to assume that the iterator
value will be NULL if the list is empty or no element found.
Otherwise it will bypass the NULL check and lead to invalid memory
access passing the check.

To fix the bug, use a new variable 'iter' as the list iterator,
while using the original variable 'rdev' as a dedicated pointer to
point to the found element.

Cc: stable@vger.kernel.org
Fixes: 2aa82191ac36 ("md-cluster: Perform a lazy update")
Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Acked-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Signed-off-by: Song Liu <song@kernel.org>
drivers/md/md.c