libstdc++: Ignore cv-quals when std::allocator<void> constructs
authorJonathan Wakely <jwakely@redhat.com>
Thu, 13 Jan 2022 21:59:13 +0000 (21:59 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Fri, 14 Jan 2022 10:14:25 +0000 (10:14 +0000)
commitfc6f1128ae603164aea6303ce2b3ed0b57e6a378
tree24e5f5da306c6f704772567d604faf1954daa2c1
parentd67ba1dce9796bff177e52e2bbb68bfa2c69a884
libstdc++: Ignore cv-quals when std::allocator<void> constructs

When I added the std::allocator_traits<std::allocator<void>>
specialization it broke code like this:

  std::allocate_shared<const int>(std::allocator<void>());

The problem is that allocator_traits<allocator<void>>::construct(a, p)
now uses std::_Construct(p), which only does a static_cast<void*>(p) and
so fails if the pointer has cv-quals.

This changes std::_Construct (and the related std::_Construct_novalue)
to use a C-style cast to (void*) which matches the effects of the
"voidify" helper in the C++20 standard.

libstdc++-v3/ChangeLog:

* include/bits/stl_construct.h (_Construct, _Construct_novalue):
Also cast away cv-qualifiers when converting pointer to void.
* testsuite/20_util/allocator/void.cc: Test construct function
with cv-qualified types.
libstdc++-v3/include/bits/stl_construct.h
libstdc++-v3/testsuite/20_util/allocator/void.cc