[media] v4l: Do not allow re-registering sub-devices
authorSakari Ailus <sakari.ailus@linux.intel.com>
Thu, 11 Aug 2016 10:18:37 +0000 (07:18 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 24 Aug 2016 19:47:24 +0000 (16:47 -0300)
commitfc49071766ed371268cc03b868cf97f21ad3f273
tree1325d101809ddb8b063f2dcb2d829fa4deb7a290
parent6a21b728732390deb75536dd9253d958ca9223d0
[media] v4l: Do not allow re-registering sub-devices

Albeit not prohibited explicitly, re-registering sub-devices generated a
big, loud warning which quite likely soon was followed by a crash. What
followed was re-initialising a media entity, driver's registered() callback
being called and re-adding a list entry to a list.

Prevent this by returning an error if a sub-device is already registered.

[mchehab@s-opensource.com: reorder logic to check if !sd before dereferencing it]
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/v4l2-core/v4l2-device.c