Remove make_cleanup_htab_delete
authorTom Tromey <tom@tromey.com>
Sun, 20 Nov 2016 20:20:32 +0000 (13:20 -0700)
committerTom Tromey <tom@tromey.com>
Wed, 11 Jan 2017 02:14:08 +0000 (19:14 -0700)
commitfc4007c969ec4208fb7c7cee2f50211a9aa0f40f
tree124c95351da6ad220406cd45875c72043259440d
parent8dbcee674ea4a8daa55f880ad7ade96efca96951
Remove make_cleanup_htab_delete

This removes make_cleanup_htab_delete in favor of destructors,
building on an earlier patch that added the htab_up typedef.

Testing revealed that more cleanup-removal work was needed in
dwarf2loc.c, so this version of the patch changes code there to use
unordered_set and vector, removing some more cleanups.

2017-01-10  Tom Tromey  <tom@tromey.com>

* utils.h (make_cleanup_htab_delete): Don't declare.
* utils.c (do_htab_delete_cleanup, make_cleanup_htab_delete):
Remove.
* linespec.c (decode_compound_collector): Add constructor,
destructor.
(lookup_prefix_sym): Remove cleanup.
(symtab_collector): Add constructor, destructor.
(collect_symtabs_from_filename): Remove cleanup.
* disasm.c (do_mixed_source_and_assembly): Use htab_up.
* compile/compile-c-symbols.c (generate_c_for_variable_locations):
Use htab_up.
* gnu-v3-abi.c (gnuv3_print_vtable): Use htab_up.
* dwarf2read.c (dw2_expand_symtabs_matching)
(dw2_map_symbol_filenames, dwarf_decode_macros)
(write_psymtabs_to_index): Use htab_up.
* dwarf2loc.c (func_verify_no_selftailcall)
(call_site_find_chain_1, func_verify_no_selftailcall)
(chain_candidate, call_site_find_chain_1): Use std::unordered_set,
std::vector, gdb::unique_xmalloc_ptr.
(call_sitep): Remove typedef.
(dwarf2_locexpr_baton_eval): Remove unused variable.
gdb/ChangeLog
gdb/compile/compile-c-symbols.c
gdb/disasm.c
gdb/dwarf2loc.c
gdb/dwarf2read.c
gdb/gnu-v3-abi.c
gdb/linespec.c
gdb/utils.c
gdb/utils.h