[InstSimplify] remove shift that is redundant with part of funnel shift
authorSanjay Patel <spatel@rotateright.com>
Wed, 23 Feb 2022 14:06:11 +0000 (09:06 -0500)
committerSanjay Patel <spatel@rotateright.com>
Wed, 23 Feb 2022 14:10:01 +0000 (09:10 -0500)
commitfc3b34c50803274b8ba3b8a30df9177b7d29063c
treeea385dcec1d5e34742470d1fbfbdd9e646714c72
parent841355c1e4e35fc02b5b171419979f5f9af0ebc8
[InstSimplify] remove shift that is redundant with part of funnel shift

In D111530, I suggested that we add some relatively basic pattern-matching
folds for shifts and funnel shifts and avoid a more specialized solution
if possible.

We can start by implementing at least one of these in IR because it's
easier to write the code and verify with Alive2:
https://alive2.llvm.org/ce/z/qHpmNn

This will need to be adapted/extended for SDAG to handle the motivating
bug ( #49541 ) because the patterns only appear later with that example
(added some tests: bb850d422b64)

This can be extended within InstSimplify to handle cases where we 'and'
with a shift too (in that case, kill the funnel shift).
We could also handle patterns where the shift and funnel shift directions
are inverted, but I think it's better to canonicalize that instead to
avoid pattern-match case explosion.

Differential Revision: https://reviews.llvm.org/D120253
llvm/lib/Analysis/InstructionSimplify.cpp
llvm/test/Transforms/InstSimplify/or.ll