[mlir] Remove `Transforms/SideEffectUtils.h` and move the methods into `Interface...
authorMahesh Ravishankar <ravishankarm@google.com>
Fri, 11 Nov 2022 17:10:38 +0000 (17:10 +0000)
committerMahesh Ravishankar <ravishankarm@google.com>
Tue, 15 Nov 2022 20:07:35 +0000 (20:07 +0000)
commitfc367dfa6770fda4adc4e5de79846f22e7e4e215
tree271b33935aaeaac87e22f05dcfccf9e0933454d0
parent9332ddfba69c38f9ceef4175b042fba0bb8e67bb
[mlir] Remove `Transforms/SideEffectUtils.h` and move the methods into `Interface/SideEffectInterfaces.h`.

The methods in `SideEffectUtils.h` (and their implementations in
`SideEffectUtils.cpp`) seem to have similar intent to methods already
existing in `SideEffectInterfaces.h`. Move the decleration (and
implementation) from `SideEffectUtils.h` (and `SideEffectUtils.cpp`)
into `SideEffectInterfaces.h` (and `SideEffectInterface.cpp`).

Also drop the `SideEffectInterface::hasNoEffect` method in favor of
`mlir::isMemoryEffectFree` which actually recurses into the operation
instead of just relying on the `hasRecursiveMemoryEffectTrait`
exclusively.

Differential Revision: https://reviews.llvm.org/D137857
31 files changed:
mlir/include/mlir/Interfaces/SideEffectInterfaceBase.td
mlir/include/mlir/Interfaces/SideEffectInterfaces.h
mlir/include/mlir/Transforms/SideEffectUtils.h [deleted file]
mlir/lib/Analysis/SliceAnalysis.cpp
mlir/lib/Conversion/SCFToGPU/CMakeLists.txt
mlir/lib/Conversion/SCFToGPU/SCFToGPU.cpp
mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt
mlir/lib/Dialect/GPU/CMakeLists.txt
mlir/lib/Dialect/GPU/Transforms/AsyncRegionRewriter.cpp
mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
mlir/lib/Dialect/SCF/Transforms/CMakeLists.txt
mlir/lib/Dialect/SCF/Transforms/ParallelLoopFusion.cpp
mlir/lib/Dialect/SCF/Utils/CMakeLists.txt
mlir/lib/Dialect/SCF/Utils/Utils.cpp
mlir/lib/Dialect/Vector/Transforms/CMakeLists.txt
mlir/lib/Dialect/Vector/Transforms/VectorDistribute.cpp
mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp
mlir/lib/Interfaces/SideEffectInterfaces.cpp
mlir/lib/Transforms/CMakeLists.txt
mlir/lib/Transforms/CSE.cpp
mlir/lib/Transforms/ControlFlowSink.cpp
mlir/lib/Transforms/Inliner.cpp
mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
mlir/lib/Transforms/Utils/CMakeLists.txt
mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp
mlir/lib/Transforms/Utils/SideEffectUtils.cpp [deleted file]
mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel