projects / kernel / kernel-generic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cd89783) | patch
drm/nouveau/fan: fix selection of fan speed when fan->get returns an error
authorMarcin Slusarz <marcin.slusarz@gmail.com>
Sun, 27 Jan 2013 14:51:09 +0000 (15:51 +0100)
committerBen Skeggs <bskeggs@redhat.com>
Wed, 20 Feb 2013 06:00:36 +0000 (16:00 +1000)
commitfc3109a2cb294335bcf3c5db5e16ae5fe68849f2
tree0f0b7c5f6fa71cf8242d66f874b98bf6d8c1b44btree | snapshot
parentcd897837eacc6ce0b883b5e6c9000cb2e5f11c39commit | diff
drm/nouveau/fan: fix selection of fan speed when fan->get returns an error

fan->get returns int, but we write it to unsigned variable, and then check
whether it's >= 0 (it always is)

Found by smatch:
drivers/gpu/drm/nouveau/core/subdev/therm/fan.c:61 nouveau_fan_update() warn: always true condition '(duty >= 0) => (0-u32max >= 0)'

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/core/subdev/therm/fan.c diff | blob | history
Domain: System / Uncategorized;