ipc: fix double sem unlock in semctl error path
authorLinus Torvalds <torvalds@linux-foundation.org>
Sat, 4 May 2013 17:25:11 +0000 (10:25 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 5 May 2013 00:19:59 +0000 (17:19 -0700)
commitfbfd1d2862a8316c7191bc551c6a842e6918abb0
tree06c5a391238bcf93bb3d7f2c587d069eeb6809e5
parent4091fd942e96af5a0b1dfa6aac5f44153ebf7cdb
ipc: fix double sem unlock in semctl error path

Fix another ipc locking buglet introduced by the scalability patches:
when semctl_down() was changed to delay the semaphore locking, one error
path for security_sem_semctl() went through the semaphore unlock logic
even though the semaphore had never been locked.

Introduced by commit 16df3674efe3 ("ipc,sem: do not hold ipc lock more
than necessary")

Acked-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
ipc/sem.c