Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit...
authorleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Apr 2012 23:44:26 +0000 (23:44 +0000)
committerleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Apr 2012 23:44:26 +0000 (23:44 +0000)
commitfbfb6e54e4e27f932db40a31d91b6a9106952fb6
tree0a7c110663979585eda587805b2059b86b9d5fa9
parentf8c8574313bfcd580bf2213295aa117527d2a123
Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83604

Reviewed by Julien Chaffraix.

Removing unnecessary definitions of absoluteRect and replacing them with a single public
version that's more explicit about its contract.

Also correcting a LayoutUnit misuse, as rects in absolute coordinates should be returned
using integers, not LayoutUnits. See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

* editing/Editor.cpp:
(WebCore::Editor::firstRectForRange):
* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::absoluteRect): Pixel snapping the local rect before converting
to absolute coordinates.
* editing/RenderedPosition.h:
(RenderedPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/editing/Editor.cpp
Source/WebCore/editing/RenderedPosition.cpp
Source/WebCore/editing/RenderedPosition.h