btrfs: track qgroup released data in own variable in insert_prealloc_file_extent
authorQu Wenruo <wqu@suse.com>
Wed, 3 Mar 2021 10:41:51 +0000 (18:41 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 15 Mar 2021 15:57:12 +0000 (16:57 +0100)
commitfbf48bb0b197e6894a04c714728c952af7153bf3
tree05f4ed21c55a0c5cb1319aa5602d6760494d3ce7
parentd2dcc8ed8ec650a793e81d8b2222146eb6ddd84f
btrfs: track qgroup released data in own variable in insert_prealloc_file_extent

There is a piece of weird code in insert_prealloc_file_extent(), which
looks like:

ret = btrfs_qgroup_release_data(inode, file_offset, len);
if (ret < 0)
return ERR_PTR(ret);
if (trans) {
ret = insert_reserved_file_extent(trans, inode,
  file_offset, &stack_fi,
  true, ret);
...
}
extent_info.is_new_extent = true;
extent_info.qgroup_reserved = ret;
...

Note how the variable @ret is abused here, and if anyone is adding code
just after btrfs_qgroup_release_data() call, it's super easy to
overwrite the @ret and cause tons of qgroup related bugs.

Fix such abuse by introducing new variable @qgroup_released, so that we
won't reuse the existing variable @ret.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c