gallium/u_threaded: fix pipe_resource leak for staging transfer
authorPierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Thu, 10 Dec 2020 13:35:34 +0000 (14:35 +0100)
committerMarge Bot <eric+marge@anholt.net>
Fri, 11 Dec 2020 21:32:31 +0000 (21:32 +0000)
commitfb7ccd3b23538eff70b5e75d518ffb01bbd06ade
treef8f80837c0b9bad2785fab66eb5aa2e073bcebf1
parentd9dd8288aa0fc273fd56b87c41f459e29aa385ab
gallium/u_threaded: fix pipe_resource leak for staging transfer

In 2900f82e191 I mistakenly used tc_set_resource_reference in both
tc_transfer_unmap and tc_call_transfer_unmap.

This causes a leak because tc_call_transfer_unmap clears dst before
acquiring a reference, so it must only be used when initializing
tc_payloads.

This fixes the perf drop reported by Marek in MR 7098.

Fixes: 2900f82e191 ("gallium/u_threaded: fix staging and non-staging conflicts")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8035>
src/gallium/auxiliary/util/u_threaded_context.c