x86,objtool: Split UNWIND_HINT_EMPTY in two
authorJosh Poimboeuf <jpoimboe@kernel.org>
Wed, 1 Mar 2023 15:13:12 +0000 (07:13 -0800)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 23 Mar 2023 22:18:58 +0000 (23:18 +0100)
commitfb799447ae2974a07907906dff5bd4b9e47b7123
tree05f8233eb66094db1be1801c5544776674c5913a
parent4708ea14bef314fc901857eefd65678236a9f2d9
x86,objtool: Split UNWIND_HINT_EMPTY in two

Mark reported that the ORC unwinder incorrectly marks an unwind as
reliable when the unwind terminates prematurely in the dark corners of
return_to_handler() due to lack of information about the next frame.

The problem is UNWIND_HINT_EMPTY is used in two different situations:

  1) The end of the kernel stack unwind before hitting user entry, boot
     code, or fork entry

  2) A blind spot in ORC coverage where the unwinder has to bail due to
     lack of information about the next frame

The ORC unwinder has no way to tell the difference between the two.
When it encounters an undefined stack state with 'end=1', it blindly
marks the stack reliable, which can break the livepatch consistency
model.

Fix it by splitting UNWIND_HINT_EMPTY into UNWIND_HINT_UNDEFINED and
UNWIND_HINT_END_OF_STACK.

Reported-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/fd6212c8b450d3564b855e1cb48404d6277b4d9f.1677683419.git.jpoimboe@kernel.org
20 files changed:
Documentation/livepatch/reliable-stacktrace.rst
arch/x86/entry/entry_64.S
arch/x86/include/asm/orc_types.h
arch/x86/include/asm/unwind_hints.h
arch/x86/kernel/ftrace_64.S
arch/x86/kernel/head_64.S
arch/x86/kernel/relocate_kernel_64.S
arch/x86/kernel/unwind_orc.c
arch/x86/lib/retpoline.S
arch/x86/platform/pvh/head.S
arch/x86/xen/xen-asm.S
arch/x86/xen/xen-head.S
include/linux/objtool.h
include/linux/objtool_types.h
scripts/sorttable.h
tools/arch/x86/include/asm/orc_types.h
tools/include/linux/objtool_types.h
tools/objtool/check.c
tools/objtool/orc_dump.c
tools/objtool/orc_gen.c