nfsd: fix race to check ls_layouts
authorBenjamin Coddington <bcodding@redhat.com>
Fri, 27 Jan 2023 16:18:56 +0000 (11:18 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 20 Feb 2023 14:20:56 +0000 (09:20 -0500)
commitfb610c4dbc996415d57d7090957ecddd4fd64fb6
treeb9b27de4fd19e6247483b6392db7c463c454cfd9
parent826b67e6376c2a788e3a62c4860dcd79500a27d5
nfsd: fix race to check ls_layouts

Its possible for __break_lease to find the layout's lease before we've
added the layout to the owner's ls_layouts list.  In that case, setting
ls_recalled = true without actually recalling the layout will cause the
server to never send a recall callback.

Move the check for ls_layouts before setting ls_recalled.

Fixes: c5c707f96fc9 ("nfsd: implement pNFS layout recalls")
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4layouts.c