tpm: use try_get_ops() in tpm-space.c
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Mon, 7 Mar 2022 20:58:03 +0000 (15:58 -0500)
committerJarkko Sakkinen <jarkko@kernel.org>
Wed, 9 Mar 2022 23:47:25 +0000 (01:47 +0200)
commitfb5abce6b2bb5cb3d628aaa63fa821da8c4600f9
tree9b793c970faa62f8e13e9474b35dd0c189ffffb3
parent590bfb57b2328951d5833979e7ca1d5fde2e609a
tpm: use try_get_ops() in tpm-space.c

As part of the series conversion to remove nested TPM operations:

https://lore.kernel.org/all/20190205224723.19671-1-jarkko.sakkinen@linux.intel.com/

exposure of the chip->tpm_mutex was removed from much of the upper
level code.  In this conversion, tpm2_del_space() was missed.  This
didn't matter much because it's usually called closely after a
converted operation, so there's only a very tiny race window where the
chip can be removed before the space flushing is done which causes a
NULL deref on the mutex.  However, there are reports of this window
being hit in practice, so fix this by converting tpm2_del_space() to
use tpm_try_get_ops(), which performs all the teardown checks before
acquring the mutex.

Cc: stable@vger.kernel.org # 5.4.x
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm2-space.c