aarch64, libgcc: Fix unwinding from pac-ret to normal frames [PR94514]
authorSzabolcs Nagy <szabolcs.nagy@arm.com>
Fri, 3 Apr 2020 09:35:41 +0000 (09:35 +0000)
committerSzabolcs Nagy <szabolcs.nagy@arm.com>
Tue, 21 Apr 2020 16:49:01 +0000 (17:49 +0100)
commitfb22faf48f6eb518932f24005f8606e5f19a7304
tree27f03a736850e068ce2537789c41f56601126414
parent1d4a3bfa8311a26814d60165b3e850cce850b61a
aarch64, libgcc: Fix unwinding from pac-ret to normal frames [PR94514]

With -mbranch-protection=pac-ret the debug info toggles the
signedness state of the return address so the unwinder knows when
the return address needs pointer authentication.

The unwind context flags were not updated according to the dwarf
frame info.

This causes unwinding across frames that were built without pac-ret
to incorrectly authenticate the return address wich corrupts the
return address on a system where PAuth is enabled.

Note: This even affects systems where all code use pac-ret because
unwinding across a signal frame the return address is not signed.

gcc/testsuite/ChangeLog:

PR target/94514
* g++.target/aarch64/pr94514.C: New test.
* gcc.target/aarch64/pr94514.c: New test.

libgcc/ChangeLog:

PR target/94514
* config/aarch64/aarch64-unwind.h (aarch64_frob_update_context):
Update context->flags accroding to the frame state.
gcc/testsuite/ChangeLog
gcc/testsuite/g++.target/aarch64/pr94514.C [new file with mode: 0644]
gcc/testsuite/gcc.target/aarch64/pr94514.c [new file with mode: 0644]
libgcc/ChangeLog
libgcc/config/aarch64/aarch64-unwind.h