selftests: cgroup: fix test_kmem_basic false positives
authorJohannes Weiner <hannes@cmpxchg.org>
Tue, 1 Aug 2023 13:56:32 +0000 (09:56 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 4 Aug 2023 20:03:42 +0000 (13:03 -0700)
commitfac2650276eced3c94bcdbc21d0e5be637c1e582
tree4a757c2c16d37d5a9b5475305a2d6b51e79eb4b0
parent17457784004c84178798432a029ab20e14f728b1
selftests: cgroup: fix test_kmem_basic false positives

This test fails routinely in our prod testing environment, and I can
reproduce it locally as well.

The test allocates dcache inside a cgroup, then drops the memory limit
and checks that usage drops correspondingly. The reason it fails is
because dentries are freed with an RCU delay - a debugging sleep shows
that usage drops as expected shortly after.

Insert a 1s sleep after dropping the limit. This should be good
enough, assuming that machines running those tests are otherwise not
very busy.

Link: https://lkml.kernel.org/r/20230801135632.1768830-1-hannes@cmpxchg.org
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/cgroup/test_kmem.c