[flang] Use X->foo() instead of X.getValue().foo() (NFC)
authorKazu Hirata <kazu@google.com>
Mon, 25 Jul 2022 07:55:06 +0000 (00:55 -0700)
committerKazu Hirata <kazu@google.com>
Mon, 25 Jul 2022 07:55:06 +0000 (00:55 -0700)
commitfac0fb4d966efe8c70d3e566cca6a5d0bd049302
tree1ce36661a5bc5a821e07e20ca23fa2d71d4b839f
parenta010d32abb9083ecf74c24876a482e5d04d1dba6
[flang] Use X->foo() instead of X.getValue().foo() (NFC)

Flang C++ Style Guide tells us to use *X when the reference is
protected by a presense test.  However, (*X).foo() is a little harder
to read, especially when X is a complicated expression.

This patch slightly deviates from the guide (but retains the spirit)
by using X->foo() instead.

Differential Revision: https://reviews.llvm.org/D130413
flang/lib/Optimizer/Transforms/AffinePromotion.cpp
flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp