Change __defineGetter__ and __defineSetter__ to respect non-configurable.
authorricow@chromium.org <ricow@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Fri, 11 Mar 2011 08:05:59 +0000 (08:05 +0000)
committerricow@chromium.org <ricow@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Fri, 11 Mar 2011 08:05:59 +0000 (08:05 +0000)
commitfa9e57e326065d0c7dd3da3f78576b473dbfd9b9
tree1b541b51d573b9fb56284c1f10366751c49d48e8
parentc17aeb55bb7c789b817f4bf6eb671cfefc54eeaf
Change __defineGetter__ and __defineSetter__ to respect non-configurable.

This makes us compatible with firefox. Earlier on we were somehow
compatible with safari - which will allow defining a getter even when
an existing getter is present and non-configurable. We would, however,
in addition to overwriting the getter also change configurable to
true. The approach used by firefox seems much more sound, i.e., why
should it be possible to use __defineGetter__ or __defineSetter__ to
overwrite a non-configurable getter or setter respectively.

I will file a bug on the webkit bugtracker.

Review URL: http://codereview.chromium.org/6658037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7143 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
src/v8natives.js
test/mjsunit/accessors-on-global-object.js
test/mjsunit/regress/regress-1240.js [new file with mode: 0644]
test/mozilla/mozilla.status