drm/i915/gt: Onion unwind for scratch page allocation failure
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 19 Oct 2020 08:34:44 +0000 (09:34 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 19 Oct 2020 11:36:38 +0000 (12:36 +0100)
commitfa812ce96a46efc27cae4dcad866aaee9cb25d28
treefb25595abd1739bab168198ce955e308dcf8d36e
parent178536b8292ecd118f59d2fac4509c7e70b99854
drm/i915/gt: Onion unwind for scratch page allocation failure

In switching to using objects for our ppGTT scratch pages, care was not
taken to avoid trying to unref NULL objects on failure. And for gen6
ppGTT, it appears we forgot entirely to unwind after a partial allocation
failure.

Fixes: 89351925a477 ("drm/i915/gt: Switch to object allocations for page directories")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201019083444.1286-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/gen6_ppgtt.c
drivers/gpu/drm/i915/gt/gen8_ppgtt.c