HID: i2c-hid: fix i2c_hid_dbg macro
authorBenjamin Tissoires <benjamin.tissoires@gmail.com>
Tue, 4 Dec 2012 15:27:46 +0000 (16:27 +0100)
committerJiri Kosina <jkosina@suse.cz>
Wed, 5 Dec 2012 09:56:45 +0000 (10:56 +0100)
commitfa738644e57d5fd54b8c0a4f5a7815972e65ce1a
tree80adc23472707f641f72a28fdc2e937ba025e395
parentee8e8806348732e328d119418a9788aabeceed0a
HID: i2c-hid: fix i2c_hid_dbg macro

This avoids the problematic case:

if (condition)
i2c_hid_dbg(ihid, "Blah blah %d\n", i);
else
do_something_very_important();

Which looks correct, however with the previous macro definition,
this expands to the unexpected:

if (condition) {
if (debug) \
dev_printk(KERN_DEBUG, &ihid->client->dev,
"Blah blah %d\n", i);
else
do_something_very_important();
}

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Reviewed-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/i2c-hid/i2c-hid.c