sctp: potential read out of bounds in sctp_ulpevent_type_enabled()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 13 Sep 2017 23:00:54 +0000 (02:00 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Sep 2017 23:59:47 +0000 (16:59 -0700)
commitfa5f7b51fc3080c2b195fa87c7eca7c05e56f673
tree1396532cdf8f95a14d447111aad03c60440aef9f
parent6fa9c623a03c560178e0dcec23f59dbfd29b21b9
sctp: potential read out of bounds in sctp_ulpevent_type_enabled()

This code causes a static checker warning because Smatch doesn't trust
anything that comes from skb->data.  I've reviewed this code and I do
think skb->data can be controlled by the user here.

The sctp_event_subscribe struct has 13 __u8 fields and we want to see
if ours is non-zero.  sn_type can be any value in the 0-USHRT_MAX range.
We're subtracting SCTP_SN_TYPE_BASE which is 1 << 15 so we could read
either before the start of the struct or after the end.

This is a very old bug and it's surprising that it would go undetected
for so long but my theory is that it just doesn't have a big impact so
it would be hard to notice.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sctp/ulpevent.h