ipv6: omit traffic class when calculating flow hash
authorMichal Kubecek <mkubecek@suse.cz>
Mon, 4 Jun 2018 09:36:05 +0000 (11:36 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Jun 2018 17:21:18 +0000 (13:21 -0400)
commitfa1be7e01ea863e911349e30456706749518eeab
treefcd60cdc288535ec0a71ba41f7e007854c53e073
parenta925ab48dacbc9ad470a9ca4c761601ee07e476c
ipv6: omit traffic class when calculating flow hash

Some of the code paths calculating flow hash for IPv6 use flowlabel member
of struct flowi6 which, despite its name, encodes both flow label and
traffic class. If traffic class changes within a TCP connection (as e.g.
ssh does), ECMP route can switch between path. It's also inconsistent with
other code paths where ip6_flowlabel() (returning only flow label) is used
to feed the key.

Use only flow label everywhere, including one place where hash key is set
using ip6_flowinfo().

Fixes: 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)")
Fixes: f70ea018da06 ("net: Add functions to get skb->hash based on flow structures")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/ipv6.h
net/core/flow_dissector.c
net/ipv6/route.c