Revert "flow_offload: action should not be NULL when it is referenced"
authorIdo Schimmel <idosch@nvidia.com>
Thu, 19 Aug 2021 10:58:42 +0000 (13:58 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Aug 2021 17:00:38 +0000 (10:00 -0700)
commitfa05bdb89b01b098aad19ec0ebc4d1cc7b11177e
treefd62e78299533dd4471809744cb69b6df665c03d
parentd584566c4b9f211fd9049b43c7fd70d424fbd0d9
Revert "flow_offload: action should not be NULL when it is referenced"

This reverts commit 9ea3e52c5bc8bb4a084938dc1e3160643438927a.

Cited commit added a check to make sure 'action' is not NULL, but
'action' is already dereferenced before the check, when calling
flow_offload_has_one_action().

Therefore, the check does not make any sense and results in a smatch
warning:

include/net/flow_offload.h:322 flow_action_mixed_hw_stats_check() warn:
variable dereferenced before check 'action' (see line 319)

Fix by reverting this commit.

Cc: gushengxian <gushengxian@yulong.com>
Fixes: 9ea3e52c5bc8 ("flow_offload: action should not be NULL when it is referenced")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://lore.kernel.org/r/20210819105842.1315705-1-idosch@idosch.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/flow_offload.h