Remove now unnecessary !s / TODO-NULLABLE comments (#25749)
authorStephen Toub <stoub@microsoft.com>
Wed, 17 Jul 2019 17:01:37 +0000 (13:01 -0400)
committerStephen Toub <stoub@microsoft.com>
Thu, 18 Jul 2019 18:25:53 +0000 (14:25 -0400)
commitf9d0787a1aa181651cd2362bb20d2ccbf5de5a69
tree189911f53d045d61f6afafdeb04debafef34cf62
parent3c0368e2854e969c20e96984d9978f3d7f7a18a2
Remove now unnecessary !s / TODO-NULLABLE comments (#25749)

* Remove !s and TODO-NULLABLE comments for [DoesNotReturn]

* Remove !s and TODO-NULLABLE comments for [NotNullIfNotNull]

* Remove !s and TODO-NULLABLE comments for writes via Interlocked.CompareExchange

* Remove !s and TODO-NULLABLE comments for Debug.Assert on fields

* Update/add several TODO-NULLABLE comments
60 files changed:
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.CreateFile.cs
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.CreateFile2.cs
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.FindFirstFileEx.cs
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.GetFileAttributesEx.cs
src/System.Private.CoreLib/shared/System/AppContext.cs
src/System.Private.CoreLib/shared/System/AppDomain.cs
src/System.Private.CoreLib/shared/System/Array.cs
src/System.Private.CoreLib/shared/System/ArraySegment.cs
src/System.Private.CoreLib/shared/System/BitConverter.cs
src/System.Private.CoreLib/shared/System/Collections/Concurrent/ConcurrentQueue.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/Dictionary.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/List.cs
src/System.Private.CoreLib/shared/System/Collections/HashHelpers.SerializationInfoTable.cs
src/System.Private.CoreLib/shared/System/Collections/ObjectModel/Collection.cs
src/System.Private.CoreLib/shared/System/Collections/ObjectModel/ReadOnlyCollection.cs
src/System.Private.CoreLib/shared/System/DateTimeOffset.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Contracts/Contracts.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs
src/System.Private.CoreLib/shared/System/Environment.Win32.cs
src/System.Private.CoreLib/shared/System/Environment.cs
src/System.Private.CoreLib/shared/System/Exception.cs
src/System.Private.CoreLib/shared/System/Globalization/CultureData.Windows.cs
src/System.Private.CoreLib/shared/System/Progress.cs
src/System.Private.CoreLib/shared/System/Reflection/Assembly.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/AsyncMethodBuilder.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ConditionalWeakTable.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ContractHelper.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/RuntimeHelpers.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/NativeLibrary.cs
src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs
src/System.Private.CoreLib/shared/System/String.Searching.cs
src/System.Private.CoreLib/shared/System/StringComparer.cs
src/System.Private.CoreLib/shared/System/Text/DecoderBestFitFallback.cs
src/System.Private.CoreLib/shared/System/Text/DecoderFallback.cs
src/System.Private.CoreLib/shared/System/Text/EncoderBestFitFallback.cs
src/System.Private.CoreLib/shared/System/Text/EncoderFallback.cs
src/System.Private.CoreLib/shared/System/Text/EncodingTable.cs
src/System.Private.CoreLib/shared/System/Text/StringBuilder.cs
src/System.Private.CoreLib/shared/System/Text/UTF8Encoding.cs
src/System.Private.CoreLib/shared/System/Threading/CancellationTokenSource.cs
src/System.Private.CoreLib/shared/System/Threading/LazyInitializer.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/Future.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/FutureFactory.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/Task.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskCompletionSource.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskScheduler.cs
src/System.Private.CoreLib/shared/System/Threading/Thread.cs
src/System.Private.CoreLib/shared/System/TimeZone.cs
src/System.Private.CoreLib/shared/System/TimeZoneInfo.Win32.cs
src/System.Private.CoreLib/src/System/Array.CoreCLR.cs
src/System.Private.CoreLib/src/System/Attribute.CoreCLR.cs
src/System.Private.CoreLib/src/System/Collections/ObjectModel/ReadOnlyDictionary.cs
src/System.Private.CoreLib/src/System/MulticastDelegate.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/ILGenerator.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/ComEventsMethod.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/EventRegistrationTokenTable.cs
src/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyDependencyResolver.cs
src/System.Private.CoreLib/src/System/StubHelpers.cs
src/System.Private.CoreLib/src/System/Utf8String.Construction.cs