Fix buglets in gdb.trace/tspeed.{exp,c}
authorSimon Marchi <simon.marchi@ericsson.com>
Fri, 12 Oct 2018 20:27:29 +0000 (16:27 -0400)
committerSimon Marchi <simon.marchi@ericsson.com>
Fri, 12 Oct 2018 20:27:29 +0000 (16:27 -0400)
commitf9c49bffe616013ba97f679afd3446a8c87d80a7
tree5e8139ea889f19b3e0bcf915f121e76c31e2bc6e
parentfe4ba873246386204af4da6bcadd8c01bb7f86c7
Fix buglets in gdb.trace/tspeed.{exp,c}

When trying to run gdb.trace/tspeed.exp, I get:

ERROR: can't read "ipalib": no such variable
    while executing
"gdb_load_shlib $ipalib"
    (procedure "prepare_for_trace_test" line 5)

This problem seems to come from commit

    c708f4d256f ("gdb: Don't call gdb_load_shlib unless GDB is running")

which moved the gdb_load_shlib call in prepare_for_trace_test.  In order
to access the ipalib variable, we need to declare "global ipalib" first.

Then, this test uses nowarnings, for no good reason I could find.  We
can remove that and fix the two trivial warnings that appear:

/home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.trace/tspeed.c: In function 'main':
/home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.trace/tspeed.c:87:16: warning: too many arguments for format [-Wformat-extra-args]
        printf ("Negative times, giving up\n", max_iters);
                ^
/home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.trace/tspeed.c:99:7: warning: implicit declaration of function 'sleep' [-Wimplicit-function-declaration]
       sleep (1);  /* set post-run breakpoint here */
       ^

gdb/testsuite/ChangeLog:

* gdb.trace/tspeed.exp: Remove nowarnings.
(prepare_for_trace_test): Declare "global ipalib".
* gdb.trace/tspeed.c: Include unistd.h.
(main): Remove superfluous printf argument.
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.trace/tspeed.c
gdb/testsuite/gdb.trace/tspeed.exp