block: Hold invalidate_lock in BLKDISCARD ioctl
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tue, 9 Nov 2021 10:47:22 +0000 (19:47 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:17:15 +0000 (19:17 +0100)
commitf9bed86a35a0cbc72196fe966644876d4279624f
treed83a5dc527ab16a684e777dd104225740d8347cb
parent876d6242d225f6be20e70746dfe7c4baabe99158
block: Hold invalidate_lock in BLKDISCARD ioctl

commit 7607c44c157d343223510c8ffdf7206fdd2a6213 upstream.

When BLKDISCARD ioctl and data read race, the data read leaves stale
page cache. To avoid the stale page cache, hold invalidate_lock of the
block device file mapping. The stale page cache is observed when
blktests test case block/009 is repeated hundreds of times.

This patch can be applied back to the stable kernel version v5.15.y
with slight patch edit. Rework is required for older stable kernels.

Fixes: 351499a172c0 ("block: Invalidate cache on discard v2")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: stable@vger.kernel.org # v5.15
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20211109104723.835533-2-shinichiro.kawasaki@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/ioctl.c