usb: chipidea: core: fix possible constant 0 if use IS_ERR(ci->role_switch)
authorXu Yang <xu.yang_2@nxp.com>
Thu, 15 Dec 2022 05:54:09 +0000 (13:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jan 2023 16:05:02 +0000 (17:05 +0100)
commitf96c0384047257365371a8ac217107c0371586f1
treec14149c6393653589ab826d7c47223e04555936d
parent74622f0a81d0c2bcfc39f9192b788124e8c7f0af
usb: chipidea: core: fix possible constant 0 if use IS_ERR(ci->role_switch)

After successfully probed, ci->role_switch would only be NULL or a valid
pointer. IS_ERR(ci->role_switch) will always return 0. So no need to wrap
it with IS_ERR, otherwise the logic is wrong.

Fixes: e1b5d2bed67c ("usb: chipidea: core: handle usb role switch in a common way")
cc: <stable@vger.kernel.org>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Link: https://lore.kernel.org/r/20221215055409.3760523-1-xu.yang_2@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/core.c