cxl: fix possible null-ptr-deref in cxl_guest_init_afu|adapter()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 11 Nov 2022 14:54:39 +0000 (22:54 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 24 Nov 2022 12:31:24 +0000 (23:31 +1100)
commitf949ccee1dde970bc77dc871b4f0b5e651577344
tree496151afc57a148d43d52264903ca64bea5f6ee5
parent1d09697ff22908ae487fc8c4fbde1811732be523
cxl: fix possible null-ptr-deref in cxl_guest_init_afu|adapter()

If device_register() fails in cxl_register_afu|adapter(), the device
is not added, device_unregister() can not be called in the error path,
otherwise it will cause a null-ptr-deref because of removing not added
device.

As comment of device_register() says, it should use put_device() to give
up the reference in the error path. So split device_unregister() into
device_del() and put_device(), then goes to put dev when register fails.

Fixes: 14baf4d9c739 ("cxl: Add guest-specific code")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221111145440.2426970-1-yangyingliang@huawei.com
drivers/misc/cxl/guest.c