Drivers: hv: vmbus: fix double free in the error path of vmbus_add_channel_work()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 19 Nov 2022 08:11:34 +0000 (16:11 +0800)
committerWei Liu <wei.liu@kernel.org>
Mon, 21 Nov 2022 10:57:41 +0000 (10:57 +0000)
commitf92a4b50f0bd7fd52391dc4bb9a309085d278f91
treea1ae08f87f16b436c0a745b80d5da701d3bad520
parentc234ba8042920fa83635808dc5673f36869ca280
Drivers: hv: vmbus: fix double free in the error path of vmbus_add_channel_work()

In the error path of vmbus_device_register(), device_unregister()
is called, which calls vmbus_device_release().  The latter frees
the struct hv_device that was passed in to vmbus_device_register().
So remove the kfree() in vmbus_add_channel_work() to avoid a double
free.

Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Suggested-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20221119081135.1564691-2-yangyingliang@huawei.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/channel_mgmt.c