ASoC: rockchip: i2s_tdm: improve return value handling
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 25 Oct 2021 18:59:33 +0000 (13:59 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 27 Oct 2021 10:31:16 +0000 (11:31 +0100)
commitf913582190ddfe2380ecf8ee87b4ff2c8dcb5d48
treefdc3e529eb0a73db7cc465a257c717e6b6e2286a
parent439c06f341aa1f09ad7def774998db1076946c98
ASoC: rockchip: i2s_tdm: improve return value handling

cppcheck reports the following warning:

sound/soc/rockchip/rockchip_i2s_tdm.c:599:9: warning: Identical
condition and return expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]

 return ret;
        ^
sound/soc/rockchip/rockchip_i2s_tdm.c:594:6: note: If condition 'ret'
is true, the function will return/exit
 if (ret)
     ^
sound/soc/rockchip/rockchip_i2s_tdm.c:599:9: note: Returning identical
expression 'ret'

 return ret;
        ^

While the code is not wrong, it's clearer to return 0 directly.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211025185933.144327-9-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_i2s_tdm.c