fbdev: tgafb: Fix potential divide by zero
authorWei Chen <harperchen1110@gmail.com>
Tue, 7 Mar 2023 13:08:56 +0000 (13:08 +0000)
committerHelge Deller <deller@gmx.de>
Tue, 14 Mar 2023 17:49:39 +0000 (18:49 +0100)
commitf90bd245de82c095187d8c2cabb8b488a39eaecc
tree3fd755c3ef8f5d2b1f008361c21266e3bc8e4623
parent33bf61c0a1a97e2abff3117751eabad28106a7c5
fbdev: tgafb: Fix potential divide by zero

fb_set_var would by called when user invokes ioctl with cmd
FBIOPUT_VSCREENINFO. User-provided data would finally reach
tgafb_check_var. In case var->pixclock is assigned to zero,
divide by zero would occur when checking whether reciprocal
of var->pixclock is too high.

Similar crashes have happened in other fbdev drivers. There
is no check and modification on var->pixclock along the call
chain to tgafb_check_var. We believe it could also be triggered
in driver tgafb from user site.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/tgafb.c