fbdev/ep93xx-fb: Do not assign to struct fb_info.dev
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 13 Jun 2023 11:06:49 +0000 (13:06 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 27 Jun 2023 07:58:49 +0000 (09:58 +0200)
commitf90a0e5265b60cdd3c77990e8105f79aa2fac994
tree78047d3aa91696933146943dfb04467f123b043f
parentbe05e207d4ec2981568a6f0c7d8ed133d2486a71
fbdev/ep93xx-fb: Do not assign to struct fb_info.dev

Do not assing the Linux device to struct fb_info.dev. The call to
register_framebuffer() initializes the field to the fbdev device.
Drivers should not override its value.

Fixes a bug where the driver incorrectly decreases the hardware
device's reference counter and leaks the fbdev device.

v2:
* add Fixes tag (Dan)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 88017bda96a5 ("ep93xx video driver")
Cc: <stable@vger.kernel.org> # v2.6.32+
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230613110953.24176-15-tzimmermann@suse.de
drivers/video/fbdev/ep93xx-fb.c