ASoC: soc-pcm: check DAI activity under soc_pcm_apply_symmetry()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 9 Mar 2021 01:07:42 +0000 (10:07 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 12 Mar 2021 14:26:25 +0000 (14:26 +0000)
commitf8fc9ec56f341c2a7aa263049340b11c9956962f
treec095feeb8884247fdaf1708aa826ecfe38f83b7a
parent0befe3a0c6126a464caa19c335afff95fb543971
ASoC: soc-pcm: check DAI activity under soc_pcm_apply_symmetry()

soc_pcm_apply_symmetry() is used like below in all cases.

if (snd_soc_dai_active(dai)) {
err = soc_pcm_apply_symmetry(fe_substream, dai);
...
}

Because of this style, the code is deep nested.
This patch checks it under soc_pcm_apply_symmetry(), and makes code simple.

static int soc_pcm_apply_symmetry(...)
{
...
=> if (!snd_soc_dai_active(...))
return 0;
...
}

=> ret = soc_pcm_apply_symmetry();
if (ret < 0)
...

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87k0qhuobl.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c