[FileCollector] Fix that the file system case-sensitivity check was inverted
authorRaphael Isemann <teemperor@gmail.com>
Tue, 16 Feb 2021 19:19:25 +0000 (20:19 +0100)
committerRaphael Isemann <teemperor@gmail.com>
Tue, 16 Feb 2021 19:21:32 +0000 (20:21 +0100)
commitf88b502d9bc7c2d7db8db340d5b98fc7f46eba9c
tree0ad5993494f529d5b895b663203158d7cc7d52a1
parentecea7218fb9b994b26471e9877851cdb51a5f1d4
[FileCollector] Fix that the file system case-sensitivity check was inverted

real_path returns an `std::error_code` which evaluates to `true` in case an
error happens and `false` if not. This code was checking the inverse, so
case-insensitive file systems ended up being detected as case sensitive.

Tested using an LLDB reproducer test as we anyway need a real file system and
also some matching logic to detect whether the respective file system is
case-sensitive (which the test is doing via some Python checks that we can't
really emulate with the usual FileCheck logic).

Fixes rdar://67003004

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D96795
lldb/test/API/functionalities/reproducers/fs-case-sensitivity/TestReproducerFSCaseSensitivity.py [new file with mode: 0644]
llvm/lib/Support/FileCollector.cpp