Revert "powerpc/rtas: Implement reentrant rtas call"
authorNathan Lynch <nathanl@linux.ibm.com>
Wed, 7 Sep 2022 22:01:11 +0000 (17:01 -0500)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 14 Sep 2022 12:43:13 +0000 (22:43 +1000)
commitf88aabad33ea22be2ce1c60d8901942e4e2a9edb
treeba41bd056270ef519fa0db5ce0cd55fcd7d9b1c0
parent71a92e99c47900cc164620948b3863382cec4f1a
Revert "powerpc/rtas: Implement reentrant rtas call"

At the time this was submitted by Leonardo, I confirmed -- or thought
I had confirmed -- with PowerVM partition firmware development that
the following RTAS functions:

- ibm,get-xive
- ibm,int-off
- ibm,int-on
- ibm,set-xive

were safe to call on multiple CPUs simultaneously, not only with
respect to themselves as indicated by PAPR, but with arbitrary other
RTAS calls:

https://lore.kernel.org/linuxppc-dev/875zcy2v8o.fsf@linux.ibm.com/

Recent discussion with firmware development makes it clear that this
is not true, and that the code in commit b664db8e3f97 ("powerpc/rtas:
Implement reentrant rtas call") is unsafe, likely explaining several
strange bugs we've seen in internal testing involving DLPAR and
LPM. These scenarios use ibm,configure-connector, whose internal state
can be corrupted by the concurrent use of the "reentrant" functions,
leading to symptoms like endless busy statuses from RTAS.

Fixes: b664db8e3f97 ("powerpc/rtas: Implement reentrant rtas call")
Cc: stable@vger.kernel.org # v5.8+
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Reviewed-by: Laurent Dufour <laurent.dufour@fr.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220907220111.223267-1-nathanl@linux.ibm.com
arch/powerpc/include/asm/paca.h
arch/powerpc/include/asm/rtas.h
arch/powerpc/kernel/paca.c
arch/powerpc/kernel/rtas.c
arch/powerpc/sysdev/xics/ics-rtas.c